fix(security): nanoid updated due dependabot warnings - #13477
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 7f37841)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 7f37841)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 63.3K · Output: 4.3K · Cached: 156K Review guidance: REVIEW.md from base branch |
Contributor
Author
|
Kilo warned me about jetbrain not being testable but it looks like updating this in there too breaks it ... @kirillk any clue why would that be? the updated version is a patch, not even a minor, why would jetbrain fail all over? |
marius-kilocode
approved these changes
Aug 27, 2026
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Bump the transitive
nanoiddependency from 3.3.17 to 3.3.18 to resolve Dependabot alert GHSA-2v37-7h3g-55p8 (nanoid: custom generators can loop indefinitely when size is zero, high severity).bun.lock: nanoid 3.3.17 -> 3.3.18packages/kilo-docs/pnpm-lock.yaml: nanoid 3.3.17 -> 3.3.18package.json: addednanoid: ">=3.3.18"override to prevent regressionWhy
Dependabot flagged nanoid (< 3.3.18) as vulnerable to an infinite loop when
customAlphabet/customRandomare called with a size of 0. The patched version for the 3.x line is 3.3.18.Testing
bun install --frozen-lockfilepasses (lockfile consistent with the new override).packages/kilo-docsvitest suite passes (22/22).packages/opencodetest suite has pre-existing failures unrelated to this change (Telemetry.trackSuggestionShown is not a function,InstanceRuntime.disposeDirectory is not a function, and ayield* Global.ServiceTypeError ineffect-flock.ts). The suggestion tests pass in isolation (12/12), confirming order-dependent test pollution rather than a regression from this dependency bump.